Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil flag client, and warn about use in future #4885

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

evankanderson
Copy link
Member

Summary

When merging #4784, I missed that I needed to update services.go to pass the flag client. This led to a nil interface in Bool() and a panic.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

This shows up real fast as a failure to publish messages when running the server. The panic is caught, but no message is published.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner November 5, 2024 18:32
@evankanderson evankanderson merged commit 45300d5 into mindersec:main Nov 5, 2024
25 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11690393097

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 5 (20.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 54.763%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/service/service.go 0 1 0.0%
internal/flags/flags.go 1 4 25.0%
Totals Coverage Status
Change from base Build 11689795417: -0.006%
Covered Lines: 15534
Relevant Lines: 28366

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants